Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kat - Personal Portfolio Site - Octos #43

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Kat - Personal Portfolio Site - Octos #43

wants to merge 12 commits into from

Conversation

kseastman
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I didn't have an H1, and the validator felt that I should, I also hadn't closed off some image and anchor tags.
Why is it important to consider and use semantic HTML? Because it makes it obvious why we are doing certain things and assists with adaptive technology like screen readers.
How did you decide to structure your CSS? Initially I wanted to structure it with general styling, and then each part of it. That got away from me fairly quickly as the css for the blog and hexagon divs got away from me and I cobbled things together.
What was the most challenging piece of this assignment? Reining in, and reminding myself that done is the new perfect.
Describe one area that you gained more clarity on when completing this assignment css grid, which is still not as in my head as flex box, but I think I have a better understanding of it.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes - good job keeping this organized
Overall This looks great! I actually said "woah" out loud when your blog posts slid over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kseastman @droberts-sea